Skip to content

fix: pin cryptography to a version working on manylinux1 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Apr 5, 2021

cryptography>=3.4 is only usable on manylinux2010+ systems becaus of the lack of a decent rust compiler on older systems.

Pin version of cryptography to 3.3.x on linux i686/x86_64.

Pre-requisite to #127

@mayeut mayeut marked this pull request as draft April 5, 2021 09:15
@mayeut mayeut force-pushed the pin-cryptography branch 2 times, most recently from a1b4ea0 to 7d1e761 Compare April 5, 2021 10:35
@mayeut
Copy link
Contributor Author

mayeut commented Apr 5, 2021

xref dockcross/dockcross#380

@mayeut mayeut force-pushed the pin-cryptography branch from e85df33 to 7d1e761 Compare April 5, 2021 14:13
@mayeut mayeut marked this pull request as ready for review April 5, 2021 14:13
@mayeut mayeut marked this pull request as draft April 7, 2021 18:23
@mayeut
Copy link
Contributor Author

mayeut commented Apr 7, 2021

re-converted to draft to test cryptography 3.3.x with new dock cross images

Edit: good to go with latest dockcross images

cryptography>=3.4 is only usable on manylinux2010+ systems because of the lack of a decent rust compiler on older systems.

Pin version of cryptography to 3.3.x on linux i686/x86_64.
@mayeut mayeut force-pushed the pin-cryptography branch from 0fb3785 to b5f0b59 Compare April 7, 2021 18:50
@mayeut mayeut marked this pull request as ready for review April 7, 2021 18:59
@jcfr jcfr force-pushed the pin-cryptography branch from c1ae577 to b5f0b59 Compare April 7, 2021 20:39
@jcfr jcfr merged commit c11ebf1 into scikit-build:master Apr 7, 2021
@mayeut mayeut deleted the pin-cryptography branch April 7, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants